[dokuwiki] Fw: Dokuwiki patch - synchronize changelog

On Sun, 22 Oct 2006 23:19:59 -0700
Ben Coburn <btcoburn@xxxxxxxxxxxxx> wrote:

> Please carefully consider the "synchronize changelog, attic, and 
> external edits" patch. The patch resolves the changelog and attic 
> issues while maintaining the efficiency of the redesigned changelog 
> code. This is accomplished by using a small amount of extra disk
> space to pre-save the current revision to the attic. By synchronizing
> the attic and changelog, the patch is also able to automatically
> generate changelog entries for external edits. I think the ability to 
> incorporate external edits into the changelog more than offsets the 
> extra disk space consumed by this approach. (This is also something
> the current code can not do.) The behavior of this patch is best seen
> on a running instance of Dokuwiki.

Before I apply this I want to make sure I (and others, hence
the reply to list) understand it.

As soon as a page edit is saved, you store a copy of it in the attic.
When an edit to this page is saved the next time, you check if an
attic file with the same timestamp as the current version exists. If it
does not exist, you know that the current version was not created
within DokuWiki and add a changelog entry for it.

Did I understand that correctly? Do others see any flaw in that logic?

One thing is that this could destroy the order in the changelog. Is
this an issue in the changelog parsing code?

As you say your self this means usually each page is stored twice,
once in pages and once in attic. Should we maybe store a 0-byte version
in the attic instead?

Andi

-- 
http://www.splitbrain.org

Other related posts: