[dokuwiki] Re: Error in css.php and js.php
- From: Anika Henke <a.c.henke@xxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Fri, 16 Jun 2006 18:58:50 +0200
Michael Klier wrote:
Personally, I am completely against replacement patterns in plugin
styles. I am not sure if a set of a few essential patterns could solve
this problem ...
2. plugins which use dokuwikis default replacement patterns
integrate in any template without the use to change their CSS
(of course only as long template authors keep the default
patterns in their templates, which IMHO is good practise if only
with the plugins in mind)
Hmm. I don't like that. Template developers' freedom should not be clipped.
I just compared the style.ini of all available templates that are using
it. Either I've missed some or there are really only 5 (!) that do so!?
(arctic, Doogie's, Minima, Monobook and ACH)
Anyway, from these 5 there are 2 that use a completely different set of
variable names.
I like Chris' suggestion best so far -- to use a small subset of
variables. (Although I contradict myself here; I only said half the
opposite before, because I think there must be a better solution ...
which I am unable to come up with.) He suggested:
> __background__
> __background_hilight__
> __text__
> __text_hilight__
> __border__
Whereas I would leave out __border__ because __text__ could be used for
borders as well (or __background_highlight__).
And maybe we should name them differently, so that it's clear that they
are persevering variables that "belong" to DokuWiki and not to the
template, like __dw_text__, etc.!?
For the default template they would be:
__dw_background__ = #fff
__dw_background_hi__ = #8cacbb
__dw_text__ = #000
__dw_text_hi = #dee7ec
What do other template developers think? Any objections to always
implement those?
And plugin developers? Is this amount of colours sufficient? Which of
those will really be needed?
I think most won't need any. Some will need background_hi and text_hi.
And very few will need all four.
Anika
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist
Other related posts:
