[dokuwiki] AW: Re: Patch: Trigger IO_WIKIPAGE_WRITE on page delete

Hi,

before I sent the patch, I asked on the list which version I should
implement, but I got no feedback. I chose the IO_WIKIPAGE_WRITE solution to
comply with the documentation on the events list (
http://wiki.splitbrain.org/wiki:events_list#io_wikipage_write ). Triggering
the event twice is standard behavior for updates (and with a little
creativity, you can declare a deletion an "update" ;-) More important, the
documentation states that on delete the variable $data[0][1] is empty. This
empty data would not be sent without the patch.

If one of the code maintainers sends me a mail, I will gladly provide a
patch that provides a IO_WIKIPAGE_DELETE event (maybe even move the deletion
code from common.php to io.php).

Greetings,

Gabriel


> -----Ursprüngliche Nachricht-----
> Von: dokuwiki-bounce@xxxxxxxxxxxxx 
> [mailto:dokuwiki-bounce@xxxxxxxxxxxxx] Im Auftrag von Guy Brand
> Gesendet: Donnerstag, 20. Dezember 2007 21:58
> An: dokuwiki@xxxxxxxxxxxxx
> Betreff: [dokuwiki] Re: Patch: Trigger IO_WIKIPAGE_WRITE on 
> page delete
> 
> On 19 December at 13:23, Gabriel Birke wrote:
> 
> > After applying this patch, DokuWiki will fire two 
> IO_WIKIPAGE_WRITE events
> > instead of one when a page is deleted. The first event has 
> no revision and
> 
>   Hi Gabriel,
> 
>   Naive question: why two times the same event and not a more specific
>   DELETE event?
> 
> 
> -- 
>   bug
> -- 
> DokuWiki mailing list - more info at
> http://wiki.splitbrain.org/wiki:mailinglist
> 

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: