[dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Chris Smith <chris@xxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Sat, 21 Oct 2006 19:53:14 +0100
Andreas Gohr wrote:
On Fri, 20 Oct 2006 16:56:14 +0100
Chris Smith <chris@xxxxxxxxxxxxx> wrote:
For my own stuff, I prefer to use an array and assign the key rather
than the button value.
e.g. <input type="submit" name="do[login]" value="<lang str>" />
$ACT = key($_REQUEST['do']);
perhaps dokuwiki could change to use the same method?
You're right, of course. I just pushed a patch to change it. Can
everyone please carefully check if I didn't break any action?
This kind of stuff really should have been tested in a RC, but I think
this is an important hook and it should be in the next release to avoid
having people to create wacky workarounds in theri plugins.
Andi
Andi,
Did the actual problem you described exist?
DokuWiki buttons are output as single button forms. The do value is set
by a hidden input element within the form - ie, its value is not a
language dependent string.
Cheers,
Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist
- Follow-Ups:
- [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Andreas Gohr
- References:
- [dokuwiki] ACTION_ACT_PREPROCESS and act_clean
- From: Andreas Gohr
- [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Chris Smith
- [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Andreas Gohr
Other related posts:
- » [dokuwiki] ACTION_ACT_PREPROCESS and act_clean
- » [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- » [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- » [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- » [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
On Fri, 20 Oct 2006 16:56:14 +0100 Chris Smith <chris@xxxxxxxxxxxxx> wrote:
For my own stuff, I prefer to use an array and assign the key rather than the button value.
e.g. <input type="submit" name="do[login]" value="<lang str>" /> $ACT = key($_REQUEST['do']);
perhaps dokuwiki could change to use the same method?
You're right, of course. I just pushed a patch to change it. Can everyone please carefully check if I didn't break any action?
This kind of stuff really should have been tested in a RC, but I think this is an important hook and it should be in the next release to avoid having people to create wacky workarounds in theri plugins.
Andi
- [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Andreas Gohr
- [dokuwiki] ACTION_ACT_PREPROCESS and act_clean
- From: Andreas Gohr
- [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Chris Smith
- [dokuwiki] Re: ACTION_ACT_PREPROCESS and act_clean
- From: Andreas Gohr