[beports] Re: [RFC] Git 1.6.0-rc3 branch

On Sat, Aug 16, 2008 at 2:11 PM, Andreas Färber <andreas.faerber@xxxxxx> wrote:
>
> Am 16.08.2008 um 15:57 schrieb scott mc:
>
>> On Sat, Aug 16, 2008 at 1:39 PM, Andreas Färber <andreas.faerber@xxxxxx>
>> wrote:
>>>
>>> Hello,
>>>
>>> I've rebased against post-1.6.0-rc3 and brought it into a form suitable
>>> for
>>> patch submission. That is, I have revised the commit messages to not end
>>> in
>>> dot and to include the necessary Signed-off-by:s. I have dropped one
>>> change
>>> from the haiku-upstream branch, the configure.ac check for libnetwork
>>> (it's
>>> added in Makefile anyway and we don't have full IPv6 support currently),
>>> and
>>> included the suppression of hardlink warnings from the haiku branch.
>>>
>>> If I don't hear any complaints I'll submit it later today.
>>>
>>> Andreas
>>>
>>>
>>
>> I can say ok to 1,3,5,6.  Patches 2 and 4 are still over my head. ;)
>> I'll defer to others on those 2.
>> Acked-by: Scott McCreary <scottmc2@xxxxxxxxx>
>
> #2 avoids Git unsuccessfully linking to libsocket. It currently checks
> whether libc has socket() and assumes it'll be in libsocket otherwise.
>

This code looks something similar to the patch i did on python in configure.in:
http://ports.haiku-files.org/browser/haikuports/trunk/dev-lang/python/python-2.5.2-haiku.diff
except on python i did a check after the socket in socket test, to
check socket in lnet, and then socket in lnetwork, which then covers
beos and haiku, or at least appeared to.  Configure then said no for
-lsocket, -lnet and yes to -lnetwork for me.

-scottmc
--
HaikuPorts homepage - http://ports.haiku-files.org
List archives: http://www.freelists.org/archives/beports
Administrative contact: brecht@xxxxxxxxxxx

Other related posts: