[3ddesktop-dev] [daenzer@debian.org: Bug#157203: 3ddesktop: wrong type for variables holding return value of getopt_long()]

Hi,

 attached is a patch from another debian developer to fix a problem on
 non-i386-like architectures.

 Cheers,

 Marcelo


-- Attached file included as plaintext by Ecartis --

Received: from ifi.informatik.uni-stuttgart.de (ifi.informatik.uni-stuttgart.de 
[129.69.211.1]) by wwwvis.informatik.uni-stuttgart.de (8.11.6/2.2) with ESMTP 
id g7IMm6r24681 for <magallmo@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>; Mon, 19 Aug 
2002 00:48:06 +0200
Received: from master.debian.org (mail@xxxxxxxxxxxxxxxxx [65.125.64.135]) by 
ifi.informatik.uni-stuttgart.de (8.9.3/2.2) with ESMTP id AAA25006 for 
<marcelo.magallon@xxxxxxxxxxxxxxxxxxxxxxxxxxx>; Mon, 19 Aug 2002 00:48:05 +0200 
(MET DST)
Received: from debbugs by master.debian.org with local (Exim 3.12 1 (Debian))
        id 17gYq3-0004P9-00; Sun, 18 Aug 2002 17:48:03 -0500
X-Loop: owner@xxxxxxxxxxxxxxx
Subject: Bug#157203: 3ddesktop: wrong type for variables holding return value 
of getopt_long()
Reply-To: "Michel Dänzer" <daenzer@xxxxxxxxxx>, 157203@xxxxxxxxxxxxxxx
Resent-From: "Michel Dänzer" <daenzer@xxxxxxxxxx>
Original-Sender: =?iso-8859-1?Q?Michel_D=E4nzer?= <daenzer@xxxxxxxxxx>
Resent-To: debian-bugs-dist@xxxxxxxxxxxxxxxx
Resent-CC: mmagallo@xxxxxxxxxx (Marcelo E. Magallon),
   3ddesktop@xxxxxxxxxxxxxxxxxxxxxx
Resent-Date: Sun, 18 Aug 2002 22:48:01 GMT
Resent-Message-ID: <handler.157203.B.102971035315536@xxxxxxxxxxxxxxx>
X-Debian-PR-Message: report 157203
X-Debian-PR-Package: 3ddesktop
X-Debian-PR-Keywords: patch
Received: via spool by submit@xxxxxxxxxxxxxxx id=B.102971035315536
          (code B ref -1); Sun, 18 Aug 2002 22:48:01 GMT
From: "Michel Dänzer" <daenzer@xxxxxxxxxx>
To: Debian Bug Tracking System <submit@xxxxxxxxxxxxxxx>
X-Mailer: reportbug 1.50
Date: Mon, 19 Aug 2002 00:39:11 +0200
Message-Id: <E17gYhT-0000rm-00@cube>
Sender: =?iso-8859-1?Q?Michel_D=E4nzer?= <daenzer@xxxxxxxxxx>
Delivered-To: submit@xxxxxxxxxxxxxxx
Resent-Sender: Debian BTS <debbugs@xxxxxxxxxxxxxxxxx>
X-Spam-Status: No, hits=0.5 required=5.0 tests=FORGED_RCVD_FOUND version=2.20
X-Spam-Level: 

Package: 3ddesktop
Version: 0.2.0-3.1
Severity: important
Tags: patch


This patch makes it do something useful on archtitectures where char is
unsigned by default. :)


diff -pur 3ddesktop-0.2.0.orig/3ddesk.cpp 3ddesktop-0.2.0/3ddesk.cpp
--- 3ddesktop-0.2.0.orig/3ddesk.cpp     2002-08-07 05:16:13.000000000 +0200
+++ 3ddesktop-0.2.0/3ddesk.cpp  2002-08-19 00:18:41.000000000 +0200
@@ -90,7 +90,7 @@ int main(int argc, char **argv)
         {0, 0, 0, 0}
     };

-    char c;
+    int c;
     int option_index;
     while (1) {

diff -pur 3ddesktop-0.2.0.orig/config.hpp 3ddesktop-0.2.0/config.hpp
--- 3ddesktop-0.2.0.orig/config.hpp     2002-08-08 03:21:13.000000000 +0200
+++ 3ddesktop-0.2.0/config.hpp  2002-08-19 00:20:46.000000000 +0200
@@ -354,7 +354,7 @@ public:

     void init_from_command_line (int argc, char **argv) {

-        char c;
+        int c;
         int option_index;

         // these are cmd line options to the daemon


-- System Information
Debian Release: testing/unstable
Architecture: powerpc
Kernel: Linux cube 2.4.19-ben0 #4 Sun Aug 11 03:06:49 CEST 2002 ppc
Locale: LANG=en_US, LC_CTYPE=en_US

Versions of packages 3ddesktop depends on:
ii  libc6                  2.2.5-14          GNU C Library: Shared libraries an
ii  libglut3               3.7-15            the OpenGL Utility Toolkit
ii  libimlib2              1.0.5-2           Powerful image loading and renderi
ii  libstdc++2.10-glibc2.2 1:2.95.4-11       The GNU stdc++ library
ii  libttf2                1.4pre.20011029-1 FreeType 1, The FREE TrueType Font
ii  xlibmesa3-dri-trunk [l 2002.08.01-1      DRI CVS trunk version of Mesa 3D g
ii  xlibs                  4.2.0-0pre1v2     X Window System client libraries

Other related posts: