FreeLists / openbeosstorage / [openbeosstorage] Re: ddm questions

[Ingo Weinhold <bonefish@xxxxxxxxxxxxxxx>]

On 2003-10-24 at 02:37:02 [+0200], you wrote:
> On 2003-10-23 at 15:13:46 [-0700], you wrote:
> > All right, I'm back in action. :-) I got some ddm questions:

Fine. :-)

> > + Do I need to copy out the data in the pointer arguments (all of which 
> > are
> > names) for the _kern_validate_set_partition_{name,content_name,type}()
> > functions? I can't really see any reason to other than truncating long
> > names, but I was planning on returning B_NAME_TOO_LONG in those instances
> > anyway.
> 
> Well, _kern_validate_set_partition_type()'s argument is a const char*, so I
> guess I know the answer for that one already,

Exactly. :-)

> but the question stands for
> the other two.

Yep, the non-const was chosen intentionally. I had the feeling, that e.g. 
truncating a name wouldn't be too unusual.

> > + Same question, but for the "parameters" parameter of
> > _kern_validate_initialize_partition(). I'm guessing no.
> 
> Again, parameters is a const char*, so nevermind, but the "name" param is a
> regular char*. Is this for name truncation again (I was intending to return
> an error if the name were too long)?

Yep, it was intended, that the disk system would truncate the name here as 
well.

> > + Do we have a limit on the length of those parameter strings? I'm
> > currently assuming no.
> 
> Still an open question. :-)

No limit in principle, but I'm with Axel here, that a sanity limit (32 KB 
should be more than enough) should apply.

CU, Ingo