FreeLists / openbeosstorage / [openbeosstorage] Re: BNodeInfo::GetTrackerIcon()

[Ingo Weinhold <bonefish@xxxxxxxxxxxxxxx>]

On Wed, 10 Mar 2004, Axel Dörfler wrote:

> Ingo Weinhold <bonefish@xxxxxxxxxxxxxxx> wrote:
> > On Wed, 10 Mar 2004, Axel Dörfler wrote:
> > > If you would be very disappointed, I could still make the changes,
> > > though :)
> > I would be grateful, if you do (and also adjust the unit tests
> > accordingly :-).
>
> Okay, I did so, but I couldn't run the unit tests under Dano; they stop
> with the message:
> FATAL: be_roster is not valid. Is the registrar running?
>
> I'll recheck under R5 soon.

And the (OBOS) registrar was running?

> > > Bad, it should be:
> > > status_t BMimeType::GetTrackerIcon(BBitmap *icon, icon_size which);
> > Yep, that sounds better. Personally I wouldn't mind, if you added it.
> > But
> > it's more a question of whether you can bend the general policy not
> > to add
> > features with a clear conscience. ;-)
> >
> > If you do, please also add a unit test and an entry in
> > docs/develop/storage/Annotations. And don't forget to document that
> > using
> > the method will break an app's R5 compatibility.
>
> Sure, maybe an entry in our secret R2 list would do, too ;-)

Yep.

CU, Ingo