FreeLists / openbeosnetteam / [openbeosnetteam] Re: moving ppp to other location

[Ingo Weinhold <bonefish@xxxxxxxxxxxxxxx>]

On 2003-09-07 at 20:01:43 [+0200], Waldemar Kornewald wrote:
>
> > And before introducing another copy of Locker.h, please use the one
> > already in our repository, and before introducing something like
> > LockerHelper, please use the class that's already there for you:
> > BAutolock.
> 
> I now even included the disk_device_manager's locker implementation.

Er, mmh, I actually planned to keep it private and remove it when a locker 
class is available in the kernel utils library. Well, I guess at least the 
interface won't change significantly, anyway. So I guess, it's OK.

> Oh, and a question that I always had:
> Should BLocker not set the semaphore's owner to B_KERNEL_TEAM (only for
> kernel-space)?

Not sure, if that is always desired. Feel free to add a constructor parameter 
that defaults to a value specifying to do that.

> To BAutolock:
> The current implementation is missing a call:
> UnlockNow(). This method is used quite frequently in PPP.
> What does it do? It unlocks the BLocker before the destructor was called.
> I have changed the implementation in my repository to support this feature
> (it is only slightly bigger than the current implementation because the
> destructor can use UnlockNow(), too).
> You probably do not like the name. :) Is Unlock() better?
> Shall I commit the change?

Unlock() is better, I think. Anyway, you should propose this on the IK team 
list. If there's agreement on the name, it should be no problem to add it, 
since it would be inline anyway, so that apps can use it without losing R5 
compatibility.

CU, Ingo