FreeLists / openbeosnetteam / [openbeosnetteam] Re: moving ppp to other location

["Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>]

"Waldemar Kornewald" <Waldemar.Kornewald@xxxxxx> wrote:
> as libkernelppp.a can now be built (woohooo! :)), I would like to 
> move it to
> some other location.
> My suggestion is to move the:
> 1) source files to:
> src/libs/kernelppp

Nope, I wouldn't put it there. First of all, we don't have kernel 
shared libs, second of all, we don't have a default location of where 
to put them, and finally, this is net stuff, and obviously a driver/
module, so I would put it into:
/src/add-ons/kernel/network/ppp
Or even a subdirectory there.
But since you only build a static library, I don't know from what it is 
going to be used? And how is your system integrated with the rest?
As I understand it, the network core stack will handle all PPP 
communication with the userland by opening your ppp module, but is 
anything else going to use it?
But I think that Philippe should have the final word there, anyway.

> 2) kernel space header files to:
> headers/private/net/kernelppp
> 
> This makes it more integrated into the system.
> 
> alternative:
> headers/libs/kernelppp

Why not just headers/private/net/ppp?

> This might be easier to find for most people.
> 
> 3) userland header files to:
> headers/os/net/ppp
> 
> alternative:
> headers/os/drivers/ppp
> 
> From userland you actually talk to a _driver_ using ioctl. On the 
> other side
> you want to access a _network_interface_. I am not really sure which 
> is
> better.

headers/os/drivers is only *for* drivers in the kernel, usually not 
userland stuff, that would probably go into os/kernel for the general 
case.
In this case, however, I would just put all PPP related user headers in 
headers/os/net/ppp, or even just one net/PPP.h file, dunno how much you 
want to put in there.

Adios...
   Axel.