Marcus Overhagen <marcusoverhagen@xxxxxxxx> wrote:
> > is it accidently or by reason that both, MediaDecoder.cpp and
> > PluginManager.cpp declare a global _plugin_manager object (two
> > different ones)??
> This is a bug. MediaDecoder.cpp should not have it's own
> plugin manager object, and a function like the
I replaced "static" with "extern", so it now uses the the global
PluginManager.
> static DecoderPlugin * GetDecoderPlugin(const media_format * format)
> should be moved into the plugin Manager. In fact, PluginManager
> already has
> status_t _CreateDecoder(Decoder **decoder, media_codec_info *mci,
> const media_format *format)
> which returns a Decoder * (not DecoderPlugin *) and also filles out
> the media_codec_info.
I've added a ToDo comment about this.
Bye,
Axel.
