FreeLists / openbeos / [openbeos] Re: [Haiku-commits] r13990 - haiku/trunk/src/add-ons/translators/jpegtranslator

[Joseph Galbraith <galb@xxxxxxxxxxx>]

Just out of curiosity, what happens if a gui app (with no
console) writes to stderr?

Also, is it not possible to return a more descriptive
error code than B_ERROR?

Optimally, the translator would be communicating this
error back to the application which would report it
however is most appropriate for the application.

It's a batch mode image processor as part of an
image processing farm, there is no user logged on
and it has no std handles: syslog.

It's a spiffy new, better than photoshop: BAlert

It is a command line image conversion tool: stderr.

Thanks,

Joseph

Jïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïï wrote:
> Author: korli
> Date: 2005-08-19 16:39:42 +0200 (Fri, 19 Aug 2005)
> New Revision: 13990
>
> Modified:
>    haiku/trunk/src/add-ons/translators/jpegtranslator/JPEGTranslator.cpp
> Log:
> now only prints to stderr (axeld suggestion)
>
>
> Modified: 
> haiku/trunk/src/add-ons/translators/jpegtranslator/JPEGTranslator.cpp
> ===================================================================
> --- haiku/trunk/src/add-ons/translators/jpegtranslator/JPEGTranslator.cpp       
> 2005-08-19 14:23:57 UTC (rev 13989)
> +++ haiku/trunk/src/add-ons/translators/jpegtranslator/JPEGTranslator.cpp       
> 2005-08-19 14:39:42 UTC (rev 13990)
> @@ -924,10 +924,7 @@
>                 }
>                 default:
>                 {
> -                       if (be_app)
> -                               (new BAlert("Wrong type", "Color space not implemented.", 
> "Quit"))->Go();
> -                       else
> -                               fprintf(stderr, "Wrong type: Color space not 
> implemented.\n");
> +                       fprintf(stderr, "Wrong type: Color space not 
> implemented.\n");
>                         return B_ERROR;
>                 }
>         }
> @@ -1059,10 +1056,7 @@
>                 switch (cinfo.out_color_space)
>                 {
>                         case JCS_UNKNOWN:               /* error/unspecified */
> -                               if (be_app)
> -                                       (new BAlert("From Type", "Jpeg uses unknown color 
> type", "Quit"))->Go();
> -                               else
> -                                       fprintf(stderr, "From Type: Jpeg uses 
> unknown color type\n");
> +                               fprintf(stderr, "From Type: Jpeg uses unknown color 
> type\n");
>                                 break;
>                         case JCS_GRAYSCALE:             /* monochrome */
>                                 // Check if user wants to read only as RGB32 or 
> not
> @@ -1094,10 +1088,7 @@
>                                         converter = convert_from_CMYK_to_32;
>                                 break;
>                         default:
> -                               if (be_app)
> -                                       (new BAlert("From Type", "Jpeg uses hmm... i don't know 
> really :(", "Quit"))->Go();
> -                               else
> -                                       fprintf(stderr, "From Type: Jpeg uses hmm... 
> i don't know really :(\n");
> +                               fprintf(stderr, "From Type: Jpeg uses hmm... i don't 
> know really :(\n");
>                                 break;
>                 }
>         }
>
> _______________________________________________
> Haiku-commits mailing list
> Haiku-commits@xxxxxxxxxxxxxxxx
> http://lists.berlios.de/mailman/listinfo/haiku-commits