FreeLists / haiku-development / [haiku-development] Re: Pairs game

[Stephan Assmus <superstippi@xxxxxx>]

Ralf Schuelke wrote:
> 
> On 2008-04-21 at 03:01:20 [+0200], Ralf Schuelke <teammaui@xxxxxx> wrote:
> > 
> > On 2008-04-20 at 19:42:26 [+0200], Axel Dörfler 
> > <axeld@xxxxxxxxxxxxxxxx> wrote:
> > > Very well done!
> > > Just a few suggestions:
> > > * as already proposed, a BMessageRunner in order to temporarily show
> > > the second choice would be a very nice addition (it feels a bit 
> > > strange now, as this game usually works differently)
> > So here is my update for better gameplay, big thanks to Michael 
> > Pfeiffer, he helps me a littel bit understand the BMessageRunner(). I 
> > hope the code is B_OK and can drop to the haiku tree and add to the 
> > image :-) i bounty this haiku.inc
> 
> SORRY :
> here the source url:
> http://tm.kaldience.com/dir/members/stargater/CPP/pairs_v1.0.1.zip

Thanks a lot for your contribution, Ralf! I have added the game to the 
source and image (demo folder).

I have made a few changes here and there: You got the coding style mostly 
right, there was only some issues with inconsistent for loops formatting. 
Then you need to make 2 empty lines between methods (again, you did it 
mostly right) and always spaces between operators, except ++ and -- (don't 
know if that last bit is required or not by our guidelines). You had 
virtual private functions in PairsView I think, which was unneeded. I also 
formatted the headers of PairsView and PairsWindow a bit differently, 
according to Michael Lotz' proposal, your version was ok, I am just 
proposing this different formatting, maybe you find it better readable as 
well. "public" and "private" are not indented, because these are so called 
"labels".

Apart from these few minor points, thanks for great contribution! Hope to 
see more from you. I have added three TODOs in the code that, if 
implemented, would make the game even more fun! Maybe with some practise 
from playing your game, I can finally beat my girlfriend at Memory! :-)

Best regards,
-Stephan