FreeLists / haiku-development / [haiku-development] Re: Screen preflet, refresh rate

["Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>]

Alexandre Deckner <alex@xxxxxxxxxxxx> wrote:
> I'm working on the Screen preflet, trying to make the revert and 
> apply 
> button deactivate correctly under vmware.
> Well, as usual, i had to dig deeper than i thought :-)
> Screen preflet uses the == operator on the screen_mode structure. The 
> comparison doesn't work because for some reason, under vmware (vesa), 
> the refresh rate gets the 'nan' value.
> I added debug output to the "*get_refresh_rate*(display_mode& mode)" 
> method and "mode.timing.h_total" and "mode.timing.v_total" can be 
> equal 
> to zero sometimes. Giving a division by zero.
> 
> Detecting the bad cases and returning a fixed 60.0Hz solves my 
> problem, 
> but i think it should be fixed deeper (vesa accelerant?). It might be 
> a 
> timing problem under emulation too (see #89)...
> Any idea?

The VESA driver obviously returned invalid timings in the display_mode 
causing the trouble; the current mode it returned wasn't completely 
initialized.
Anyway, should be fixed with r24190. However, this will currently only 
work correctly if the mode in question is found in the mode list (which 
is fixed at this point).

Bye,
   Axel.