FreeLists / dokuwiki / [dokuwiki] Re: [BUG] Dokuwiki broken after 'darcs pull'

[Harry Fuecks <hfuecks@xxxxxxxxx>]

Apologies - my fault - had "fixed" this due to a failing test and
should have looked more carefully.

Using PHP 5.0.5 and running the init_getID_test (which is testing the
getID() function), one of the tests was passing something _other_ than
an array or string to the function which results in a warning about
foreach being passed an invalid variable.

The section in question should probably be changed to something like;

  if ( !is_array($str) || !is_string($str) ){
   return;
 }


On 11/8/05, Timo Silbär Falk <Timo.Falk@xxxxxx> wrote:
> Am Tue, 8 Nov 2005 09:57:11 +0100 schrieb Timo "Silbär" Falk:
>
> > Hi!
> >
> > I have just done a 'darcs pull' an my wiki is broken :-(
> > I think I've found the/one reason:
> > ---- init.php ----
> > if ( defined($conf['lang']) ) {
> >   require_once(DOKU_INC.'inc/lang/'.$conf['lang'].'/lang.php');
> > }
> >
> > ---- snip ----
>
> It seems there is an other change that broke my wiki:
>
> ----- utf8.php -----
> function unicode_to_utf8( &$str ) {
>
>   // init_getID_test causes something to get
>   // passed to this function that isn't a string
>
>   if ( !is_string($str) ){
>     return;
>   }
> ---- snip ---
>
> Not only /init_getID_test/, but /utf8_strtolower/ *always* pass an array
> and /utf8_strtolower/ is called by /getID/ and so /getID/ always returned
> an empty string....
>
> If I comment the lines out, everything is like before.
>
> Silbär
> --
> "Wie? Schwanger?!" - http://www.20six.de/silbaer
>
> --
> DokuWiki mailing list - more info at
> http://wiki.splitbrain.org/wiki:mailinglist
>
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist