Go to the FreeLists Home Page Home Signup Help Login
 



Browse dokuwiki: This Month's Archive    Main Archive Page    Related posts

[dokuwiki] Re: New changelog system

  • From: Ben Coburn <btcoburn@xxxxxxxxxxxxx>
  • To: dokuwiki@xxxxxxxxxxxxx
  • Date: Sun, 3 Sep 2006 17:17:59 -0700

On Sep 3, 2006, at 12:16 PM, Andreas Gohr wrote:

I like it how the changelog conversion is implemented as action
plugin. One minor thing I'd add: the plugin should try to disable
itself after finishing the conversion. There is no need to
instanciate the whole plugin when it does nothing anymore. This of
course only works if the plugin directory is writable, so in
addition the ?do=check command should check if the import was
finished but the plugin is still enabled and issue an warning about
it.


Sounds good, but how do users re-enable it if they need to re-run the import. I put 'importoldchangelog' in the $plugin_protected list of the plugin manager. This disables all the plugin manager form elements for the 'importoldchangelog' plugin. Should the plugin manager be changed to allow protected plugins that are disabled to be re-enabled?

Hmm. Why should a user want to re-run the import if it finished
successfully the first time? I think there is no need to set this plugin
to protected.



You're right... I don't know what I was thinking when I wrote that.

Just another addition: Maybe we should move all the changelog code
from common.inc to it's own file?


Well, 'inc/common.php' is getting large but these function always need to be included. I think this is just a project management issue, so it's your call Andi.

Right. I'd say common.inc is getting big so let's move the changelog
stuff. If you like do it with your patches mentioned above or I'll do it
afterwards. Maybe we should move all recent changes/history related
stuff with it.



I'll do this with the update patches. The functions will go in 'inc/changelog.php' with an include in 'inc/common.php'.


Regards, Ben Coburn


------------------- silicodon.net -------------------

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts:

  • [dokuwiki] New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system
  • [dokuwiki] Re: New changelog system




  • [ Home | Signup | Help | Login | Archives | Lists ]

    All trademarks and copyrights within the FreeLists archives are owned by their respective owners.
    Everything else ©2007 Avenir Technologies, LLC.