FreeLists / dokuwiki / [dokuwiki] Re: Email Notify patch added - some work needed

[Steven Danz <steven-danz@xxxxxxxxx>]

Andreas Gohr wrote:

> Hi all!
>
> I just added Steven Danz's email tracking patch. I did some changes already which should make the code a little bit more compact. However I have some things I'd like to see changed - Would be cool if you Steven could do them :-)
>  
Will do, just glad to help!

> I think the whole thing should be optional. So a config option $conf['subscribers'] = 0|1 would be nice.
>  
Good point, should have see that one coming. 

> The messages shown on subscription/unsubscription should be moved to the language file.
>  
Sigh, its been awhile since I've worked in a multi-lingual environment, 
and I keep forgetting this one.  Since my language skills are lacking 
for everything but English, any help is appreciated.

> The stuff which does send the notification should be put in it's own function and should use it's own textfile in the language folder.
>  
I was leveraging the current notify() function since I guessed that the 
admin wouldn't want to get two messages (if they happened to subscribe 
to receive notices) and the email formatting/sending language issues 
were already handled there, i.e. the notify() function would handle 
any/all notifications that DokuWiki was up to.  Are you intending that 
there be a duplicate notify() to the function that is there now?  I'm 
probably missing the point.

> Another thing that may make sense is to introduce a "minor change" box for the edit window. Mails shouldn't be send on minor changes. I'm not sure yet how to handle this. Should it be on by default or off? Steve: no need to implement this one right away - I just want to hear the opinion from all of you about this feature. It's available in most other wiki engines - has anyone experience if it works as intended?
>  
I'm starting to get requests for something similar ( amazing how touchy 
folks get after their email boxes start filling up ;-) ), but I've been 
putting it off for the lack of a good metric for a 'minor change'.  As 
admin, I'd almost like it for the admin change email as well.

> Andi
>  
As soon as I get my darcs area 'fixed' (I'm a recovering CVS user and I 
think I messed up the 'darcs pull') I'll be sending along some patches.

Thanks again!

Steven
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist