FreeLists / dokuwiki / [dokuwiki] Re: [patch] install.php readable

[Francisc Rusznyak <francisc@xxxxxxxxxxx>]

Thanks for your answer, and sorry for my misunderstanding in the curren
code structure/style.

In this case please ignore the patch. I will undo my changes and then
start fixing bugs, instead of wasting time changing timgs that already
work :)

Franz

Am Sonntag, den 11.05.2008, 12:43 +0100 schrieb Christopher Smith:
> Franz, one of the aspects of working on a project with others is to be  
> flexible in your own programming style - so that you can write code  
> that matches the style of the code already in the project.   
> Consistency across a project is important.  Its easily possible to  
> argue the merits of one particular style over another.  Its one of  
> those questions for which there is no real right answer and for which  
> there is no point wasting time arguing.  For better or for worse the  
> style gets set by the first people who are in charge of the project.   
> After that, just try to follow that style.
> 
> Its not sensible to restyle one file so it is at odds with the rest of  
> the project.  For all that I also think some of your changes don't  
> make sense.
> - A heredoc is the most sensible construct for the embedded ACL file  
> data.  The file data is pasted unmodified between the heredoc  
> delimiters with no modification necessary.  A concatenation of strings  
> with all their escaping of characters is way more messy and the  
> ability to paste a correct file without modification is lost.
> - The print for echo seems to be change for change sake (fyi 
> http://www.faqts.com/knowledge_base/view.phtml/aid/1/fid/40) 
> .
> 
> - Chris

-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist