FreeLists / dokuwiki / [dokuwiki] Re: Add: changing double quote marks

[Chris Smith <chris@xxxxxxxxxxxxx>]

Werner Flamme wrote:
> Chris Smith schrieb:
>   
> >   
> >     
> > Why not raise a bug report / feature request at bugs.splitbrain.org?
> >     
>
> Last time I dared to complain about the config plugin, I received a "Its
> not really the config plugin, it can't tell your intentions" ;-)
>   

Still no harm in raising a bug report, it can always be turned down.  
However, this time you are on to something ;), the config plugin won't 
properly read any string containing a semi-colon - it thinks the first 
semi-colon it reaches in the config setting value is the end of a php 
statement, when in fact is only some character in a string.  Try the 
following as your wiki title

"; this is my wiki!"

Why I say raise a bug report is that things here don't necessarily get 
remembered if they aren't fixed straight away.

I have worked out a better pattern, however I reckon it can still be 
fooled, its just less likely to occur.

If you want to modify the code yourself, you can try replacing the 
pattern assignment on line #128 of 
lib/plugins/config/settings/config.class.php with:

       $pattern = '/\$'.$this->_name.'\[[\'"]([^=]+)[\'"]\] ?= 
?(.*?);(?=[^;]*(?:\$'.$this->_name.'|@include|$))/';

I have tried it and it will read in html entities and other strings 
containing semi-colons. It can be tripped up if your string includes
";" followed by "$conf" or "@include".  I think they are less likely 
combinations and should fix the problem at least until a truly robust 
solution can be found.

Cheers,

Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist