FreeLists / dokuwiki / [dokuwiki] Re: Re2: Some Patches...

[Christopher Smith <chris@xxxxxxxxxxxxx>]

On 15 Mar 2008, at 13:38, fabidev@xxxxxxxx wrote:

> > > common tools for PHP4.zip
> hmm, i had one plugin witch not work in PHP4 (a friend report me the  
> problem on his PHP4 and i make this patch for him)
> the functions comes from the plugin badbehaviour, this need it for  
> example (are included in it)
You should have included that in your initial patch description.  A  
grep of my dev dokuwiki installation shows stripos() calls in two  
third party scripts, simplepie (core) and badbehaviour (plugin).  Both  
of these provide their own implementation of the function for  
installations that are missing it.  I'm not sure what happened in your  
friend's wiki, but it sure looks like a missing stripos() shouldn't be  
a problem.

> > > css improvement.zip
> i have used a background color for mous-over, this deletes the  
> Pictures of the media files and put the background color behind the  
> visible pictures, this is unwanted. The patch correct this.
Ok, I still don't see the point in including a patch to fix something  
that is specific to some other changes you have made on your wiki.
> > > image-class for shown pictures.zip
> similar response like "css improvement.zip"
ditto.

> > > linebreak.zip
> - It down't break "a whole host of test cases", only the Simpel-Test  
> for linebreaks. This is only interesting fore developers, not for  
> users. And a pro developer with knowledge in Simpel-Test fix this in  
> 30 seconds, i think. (i am not a pro developer)
I'm not sure about that.  In doing the recent patches to just that  
piece of code I had to fix 30 odd broken tests.  Take a look through  
the test case code, it really very easy to follow and consequently  
very easy to write new tests and update old ones.
> If you see a better cleaner way to implement this option, i am very  
> interested ! :-)
Read recent mails on the topic in the mailing list, get hold of the  
current development version for the complete set of patches.
One of the things to guard against with any piece of software is  
"feature bloat".  Where things keep being added to an application to  
satisfy the needs of a particular group of users.  As time passes the  
software gets larger and larger, harder and harder to maintain, slower  
and slower.  For me DokuWiki hasn't fallen into this trap.  It has  
made itself extendable through templates, plugins and settings files  
like acronyms and interwikis.
You might want to take a look at the plugin & template system as a way  
of accomplishing your changes.  Its then easier to package up your  
change(s) into a form others can use if they like it.  The burden of  
maintaining those changes doesn't transfer to DW itself.  If lots of  
people use the template or plugin, you'll have other people who will  
help out with enhancing and maintaining the plugin/template.  A patch  
to DW is then only necessary if there is no way to make the  
enhancement without altering the core or to fix a bug.
-Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist